Conversation
doutriaux1
approved these changes
Dec 9, 2025
Collaborator
doutriaux1
left a comment
doutriaux1
left a comment
There was a problem hiding this comment.
@jwhite242 this looks good, just a quick question about six.
| if args.autoyes: | ||
| ok_cancel = "y" | ||
| else: | ||
| ok_cancel = six.moves.input("Are you sure? [y|[n]]: ") |
Collaborator
There was a problem hiding this comment.
Do we still need six here?
Collaborator
Author
There was a problem hiding this comment.
no, but i'm not gonna rip it out/refactor the cli's inputs on this pr; yanking it is on the todo list, but on the backlog since it's not really a critical issue given it's still working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add autoyes flag to cancel command for easier automated usage